feat: add hostnames and connecting IP CIDR fields to network ACL match schema#1386
Draft
harshithRai wants to merge 2 commits into
Draft
feat: add hostnames and connecting IP CIDR fields to network ACL match schema#1386harshithRai wants to merge 2 commits into
harshithRai wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
=======================================
Coverage 79.84% 79.84%
=======================================
Files 153 153
Lines 7052 7052
Branches 1547 1547
=======================================
Hits 5631 5631
Misses 781 781
Partials 640 640 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Extends the Network ACL
matchandnot_matchschema to support three new fields introduced in the Auth0 Management API:hostnames- list of hostname strings, allowing rules to match/block traffic to the tenant's canonical domainconnecting_ipv4_cidrs- list of IPv4 CIDR strings (same format as ipv4_cidrs)connecting_ipv6_cidrs- list of IPv6 CIDR strings (same format as ipv6_cidrs)These fields are optional and follow the same shape as existing array match fields.
🔬 Testing
Three new unit tests added to
test/tools/auth0/handlers/networkACLs.test.ts, one per new field, verifying that schema validation passes when each field is used in a rule'smatchornot_match.📝 Checklist