Improve the provide function in order to allow passing a factory function#663
Open
LcsGa wants to merge 1 commit intoauth0:mainfrom
Open
Improve the provide function in order to allow passing a factory function#663LcsGa wants to merge 1 commit intoauth0:mainfrom
provide function in order to allow passing a factory function#663LcsGa wants to merge 1 commit intoauth0:mainfrom
Conversation
… a factory function
b722a39 to
06382a6
Compare
Author
|
About the |
Contributor
|
Hi @LcsGa, thank you for contributing to Auth0! |
|
Hi! any news on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some cases, we could need to use some other providers in order to configure auth0.
In this regard, I added the possibility to also provide a factory function and not just a basic value to allow this.
Testing
There is no existing unit tests for this provide function.
You can manually test it by playing with the playground, using this provide function and passing a factory function instead of an object.
Checklist