UPSTREAM PR #1222: improve handling of VAE decode failures #48
+48
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loci-dev
temporarily deployed
to
stable-diffusion-cpp-prod
GitHub Actions
Inactive
|
No summary available at this time. Visit Loci Inspector to review detailed analysis. |
loci-dev
force-pushed
the
main
branch
24 times, most recently
from
68f62a5 to
342c73d
Compare
loci-dev
force-pushed
the
main
branch
2 times, most recently
from
8c51734 to
3ad80c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: leejet/stable-diffusion.cpp#1222
for cases like leejet/stable-diffusion.cpp#1220
The cli should no longer save an empty image to disk if the generation failed. If no imge is sucessfuly saved, it should exit with error code -1 instead of 0. (Maybe I should change it to return -1 if any image failed to be saved?)