Add CodeQL query to check for allocations not preceeded by ensure_free#2104
Draft
pguyot wants to merge 1 commit intoatomvm:mainfrom
Draft
Add CodeQL query to check for allocations not preceeded by ensure_free#2104pguyot wants to merge 1 commit intoatomvm:mainfrom
pguyot wants to merge 1 commit intoatomvm:mainfrom
Conversation
pguyot
force-pushed
the
w07/add-codeql-allocation-without-ensure-free
branch
from
f2e7ae2 to
f5352be
Compare
pguyot
force-pushed
the
w07/add-codeql-allocation-without-ensure-free
branch
from
f5352be to
2f620f0
Compare
Fix several cases where this happened in nifs. Also add a NOLINT comment for cases where the query is not smart enough to remove the couple of false positives. Also clean up some CodeQL logic and fixed a cleanup in dac_driver.c if allocation failed Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w07/add-codeql-allocation-without-ensure-free
branch
from
2f620f0 to
91e96d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of
enif_make_resource*in favor ofterm_from_resource*#2108Fix several cases where this happened in nifs. Also add a NOLINT comment
for cases where the query is not smart enough to remove the couple of
false positives.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later