This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Reword issue-opening part of the error tooltip#322
Open
Conversation
jasonrudolph
approved these changes
Feb 9, 2018
Contributor
jasonrudolph
left a comment
There was a problem hiding this comment.
Thanks, @50Wliu.
I explored a few other potential phrasings, but I haven't identified anything that seems like a real winner. I'm happy to merge this pull request as is, but I'll offer one alternative to see what you think:
If the problem persists, please open an issue to share these diagnostics.
If you like that better, feel free to make that update and merge this pull request.
If you like it better as is, feel free to merge the pull request as is.
Thanks for taking the time to make this improvement. 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide before submitting any pull requests.
Requirements
Description of the Change
Modify the part of the error tooltip that suggests opening an issue.
Before:
If the problem persists, visit [atom/teletype] and open an issue.After:
If the problem persists, please [open an issue].Alternate Designs
Alternate wording. I am open to suggestions.
Benefits
I think this makes it clearer that the issue will be prefilled rather than asking you to fill out the information yourself.
Possible Drawbacks
Loss of
atom/teletypein the issue message.Verification Process
Turn off internet and look at the error component. Click on the "open an issue" part to make sure it leads to a prefilled issue template.
Applicable Issues
#317 (comment)