Skip to content

Esa gaia issue1325 cone search and query object#3539

Merged
bsipocz merged 5 commits intoastropy:mainfrom
esdc-esac-esa-int:ESA_gaia-issue1325_cone_search_and_query_object
Mar 10, 2026
Merged

Esa gaia issue1325 cone search and query object#3539
bsipocz merged 5 commits intoastropy:mainfrom
esdc-esac-esa-int:ESA_gaia-issue1325_cone_search_and_query_object

Conversation

@Enriquerzrz
Copy link
Copy Markdown
Contributor

Hi, this is my first contribution to this repository. My name is Enrique Ruiz, and I work at Starion for ESA (SCO-08), at ESAC, mainly involved in development and maintenance of the Survey Data Archives.

This PR updates the Gaia package to enforce .14f formatting for RA/DEC/radius in cone_search and query_object, ensuring consistent ADQL queries across Python versions.

CC: @esdc-esac-esa-int
Jira: GAIAPCR-1325

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.67%. Comparing base (e49f51a) to head (36dc9dd).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3539      +/-   ##
==========================================
+ Coverage   72.66%   72.67%   +0.01%     
==========================================
  Files         219      219              
  Lines       20478    20487       +9     
==========================================
+ Hits        14880    14889       +9     
  Misses       5598     5598              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz added the gaia label Feb 27, 2026
@bsipocz bsipocz added this to the 0.4.12 milestone Feb 27, 2026
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Feb 27, 2026

Welcome Enrique and thank you for your PRs!

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the code looks OK. However the tests are overcomplicated and I would instead recommend to add get_query_payload to the public API which would/should return the query string instead of sending it to the server.

That would be then suitable for testing, debuging, and also would help the users.

Comment thread astroquery/gaia/tests/test_gaiatap.py Outdated
Comment thread astroquery/gaia/tests/test_gaiatap.py Outdated
@jespinosaar
Copy link
Copy Markdown
Contributor

Good job @Enriquerzrz ! All the checks are passing. Please have a look at the comments from @bsipocz and let us know if you have any doubt.

@jespinosaar
Copy link
Copy Markdown
Contributor

It seems you already did it 😆

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, thank you so much for the review follow-up.

I have very minor comments that I'll just directly commit and then merge the PR.

Comment thread CHANGES.rst
Comment thread astroquery/gaia/core.py Outdated
Comment thread astroquery/gaia/core.py Outdated
Comment thread astroquery/gaia/core.py Outdated
Comment thread astroquery/gaia/core.py Outdated
@bsipocz bsipocz merged commit f450265 into astropy:main Mar 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants