Fix CLDDP test regularization initial value

[astomodynamics]

Summary

• Updates regularization initial value from 1e-7 to 1e-6 in CLDDP solver test to fix test failure

Changes

• Modified tests/cddp_core/test_clddp_solver.cpp to use more appropriate regularization value

Test plan

• Run CLDDP solver tests to verify they pass with the updated regularization value

[gemini-code-assist]

Summary of Changes

Hello @astomodynamics, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific test failure within the CLDDP solver by adjusting a configuration parameter. The change involves modifying the initial regularization value to a more appropriate setting, ensuring the test suite passes reliably and maintains the integrity of the solver's validation process.

Highlights

• CLDDP Test Regularization: The initial regularization value in the CLDDP solver test has been updated from "1e-7" to "1e-6" to resolve a test failure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a test failure in the CLDDPTest::SolveCar test by adjusting the initial regularization value from 1e-7 to 1e-6. This is a sensible change that aligns the parameter with the solver's default and likely enhances numerical stability. My review includes one suggestion related to improving code maintainability by removing redundant option initializations in the test setup.

[gemini-code-assist]

This line sets the regularization initial value to 1e-6, which is its default value. I noticed that several other options in this test are also explicitly set to their default values (e.g., acceptable_tolerance, verbose, debug). To improve code clarity and reduce redundancy, consider removing the explicit assignments for all options that use their default values. This would make the test setup cleaner by only highlighting the non-default parameters.