Skip to content

Make BoxPredicate::find_case use the inner find_case#200

Merged
epage merged 3 commits intoassert-rs:masterfrom
rynoV:master
Feb 11, 2026
Merged

Make BoxPredicate::find_case use the inner find_case#200
epage merged 3 commits intoassert-rs:masterfrom
rynoV:master

Conversation

@rynoV
Copy link
Contributor

@rynoV rynoV commented Jan 31, 2026

So that test failures still show nicely when using boxing. For example this is the failing test case output:

  left: "Case { predicate: \"Some(var > 5)\", result: false, products: [(\"var\", 4)], children: [] }"
 right: "Case { predicate: \"Some(var > 5)\", result: false, products: [], children: [] }"

Showing that previously the debug information was missing when using find_case

@rynoV rynoV marked this pull request as ready for review January 31, 2026 21:21
@epage
Copy link
Contributor

epage commented Feb 2, 2026

So that test failures still show nicely when using boxing. For example this is the failing test case output:

  left: "Case { predicate: \"Some(var > 5)\", result: false, products: [(\"var\", 4)], children: [] }"
 right: "Case { predicate: \"Some(var > 5)\", result: false, products: [], children: [] }"

Showing that previously the debug information was missing when using find_case

Note that we generally ask for tests to be added in a commit before a fix, showing the existing behavior. This would make the commit with the fix show how behavior changed.

@coveralls
Copy link

coveralls commented Feb 2, 2026

Pull Request Test Coverage Report for Build 21893190485

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+7.6%) to 15.331%

Files with Coverage Reduction New Missed Lines %
src/boxed.rs 1 43.75%
Totals Coverage Status
Change from base Build 21554052073: 7.6%
Covered Lines: 109
Relevant Lines: 711

💛 - Coveralls

@rynoV
Copy link
Contributor Author

rynoV commented Feb 3, 2026

Thanks, re-ordered the commits and merged in master

@epage
Copy link
Contributor

epage commented Feb 3, 2026

We actually ask that there be no merge commits and recommend rebasing

@rynoV
Copy link
Contributor Author

rynoV commented Feb 4, 2026

done

@rynoV
Copy link
Contributor Author

rynoV commented Feb 11, 2026

that should be ci fixed now

@epage
Copy link
Contributor

epage commented Feb 11, 2026

Thanks!

@epage epage merged commit ce8099e into assert-rs:master Feb 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants