fix(coderd): improve password reuse error message in OTP reset flow#5
Draft
karan-gupta-glean wants to merge 1 commit intomainfrom
Draft
fix(coderd): improve password reuse error message in OTP reset flow#5karan-gupta-glean wants to merge 1 commit intomainfrom
karan-gupta-glean wants to merge 1 commit intomainfrom
Conversation
Update the error returned when a user attempts to reset their password to the same value. The new message is clearer and more actionable. Add a dedicated unit test for this password-reuse scenario. Generated by Glean Code Writer
karan-gupta-glean
added
the
glean-code-writer
glean-github-app-oauth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a user attempted to reset their password to the same
value via the OTP flow, the error message was "New password cannot match
old password." This phrasing is slightly ambiguous — it could be read as
"new password is not able to match" rather than "new password must not
match."
Updated the message to "New password must be different from your current
password." which is clearer and more actionable.
Also added a dedicated
CannotReuseOldPasswordunit test that waspreviously missing for this specific code path.
🤖 Generated by Glean Code Writer
📝 Chat link - https://app.glean.com/chat/a0bba6beb39043498ad0e2061fea6d71