Open
Conversation
…and exceptions - Added 15 missing data type classes per RWZ spec - Fixed incorrect action-to-data-type mappings - Added all exception element cases (0x1F4-0x21B) - Fixed RuleHeader separator logic for last rule - Made input file path configurable via CLI argument - Replaced hard assertions with softAssert for graceful error handling - Successfully tested against Outlook 2019 file with 137 rules
|
Hey @asklar just wondering if you encountered any problems with the specification when you made this? I'm keen to make sure it's accurate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds complete rule element support for parsing Outlook 2019 .rwz files with all conditions, actions, and exceptions per the RWZ Format Specification.
The original parser only handled ~15 element types and crashed on unknown IDs. This update adds support for all documented element types, enabling successful parsing of real-world .rwz files.
Changes
process.argv[2])Testing
Successfully parsed an Outlook 2019 .rwz file containing 137 rules with 0 errors.