feat(scheduler): add per-pool scheduling outcome metrics #4591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejanzele
force-pushed
the
feat/pool-scheduling-metrics
branch
4 times, most recently
from
dc32c4d to
1ad6afe
Compare
Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
dejanzele
force-pushed
the
feat/pool-scheduling-metrics
branch
from
1ad6afe to
2f736dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
What this PR does / why we need it
Adds per-pool scheduling metrics to track success/failure outcomes for each pool independently.
Currently a scheduling failure in one pool causes the entire cycle to fail with a single error. These metrics enable:
New metrics:
armada_scheduler_pool_scheduling_outcome- counter with labelspool,outcome(success/failure)armada_scheduler_pool_scheduling_errors- counter with labelspool,error_type(context_creation/schedule/upsert)Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer