Consolidate duplicate theme toggle code into shared JS module#4
Merged
arjun7965 merged 3 commits intobasic_htmlfrom Nov 12, 2025
Merged
Consolidate duplicate theme toggle code into shared JS module#4arjun7965 merged 3 commits intobasic_htmlfrom
arjun7965 merged 3 commits intobasic_htmlfrom
Conversation
Co-authored-by: arjun7965 <15646612+arjun7965@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update dark mode and menu enhancements based on feedback
Consolidate duplicate theme toggle code into shared JS module
Nov 12, 2025
arjun7965
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme toggle implementation was duplicated across
index.html(lines 79-100) andbooks.html(lines 51-65, 188-191), violating DRY principles.Changes
js/theme.js: Extracted theme initialization, toggle function, and icon state management into shared module<script src="js/theme.js"></script>referenceResult
Net -17 lines across codebase. Theme logic now lives in single source of truth, simplifying future maintenance.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.