This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Chore: Remove Endpoints ownerRef workaround for fixed k8s issue #28483#733
Open
Mangaal wants to merge 4 commits intoargoproj:masterfrom
Open
Chore: Remove Endpoints ownerRef workaround for fixed k8s issue #28483#733Mangaal wants to merge 4 commits intoargoproj:masterfrom
Mangaal wants to merge 4 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
==========================================
- Coverage 54.26% 53.58% -0.69%
==========================================
Files 64 64
Lines 6164 6508 +344
==========================================
+ Hits 3345 3487 +142
- Misses 2549 2745 +196
- Partials 270 276 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the special handling logic for Kubernetes Endpoints resources that was added as a workaround for an upstream bug.
The code responsible for adding a Service as an owner reference to Endpoints with no existing owners is now deleted.
Why is this change being made?
The original issue, tracked in kubernetes/kubernetes#28483, has been fixed in recent versions of Kubernetes.