Mixed naming of central and peripheral in examples#232
Open
mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Mixed naming of central and peripheral in examples#232mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
Fixed the names and comments to not confuse the users.
per1234
added
type: imperfection
Contributor
Author
|
What I can do to accelerate approval of that PR ? |
Contributor
Author
|
@facchinm You do not want this change? There are several PRs waiting, and no comment or merged. |
Contributor
Author
|
Bump, any answer on the integration ? I wonder why it takes so long... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the names and comments to not confuse the users.
The BLE central can start connection to peripheral, not vice versa.
The most confusing one was that we wait for peripherals to connect, and next comment name the variable that it is central. :)