This repository was archived by the owner on Jul 30, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 158
[aips] Add AIP-88 FAQ #1008
Merged
Merged
[aips] Add AIP-88 FAQ #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grao1991
reviewed
Jul 2, 2025
76b5a00 to
7a9a9bd
Compare
7a9a9bd to
ed62fac
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds the AIP-88 FAQ page for block epilogue transactions and registers it in the site metadata.
- Introduce
aip-88.mdxwith detailed FAQ and example JSON output for the new Block Epilogue transaction - Update
_meta.tsxto include the AIP-88 entry in the AIPs navigation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/nextra/pages/en/build/aips/aip-88.mdx | Add Block Epilogue Transactions FAQ document for AIP-88 |
| apps/nextra/pages/en/build/aips/_meta.tsx | Register AIP-88 title in metadata mapping |
Comments suppressed due to low confidence (2)
apps/nextra/pages/en/build/aips/aip-88.mdx:55
- The JSON example includes the "state_checkpoint_hash" field, but the new Block Epilogue transaction may not include this field. Please confirm whether this should be present and update the example accordingly.
"state_checkpoint_hash":"0x841a43956ca09a02b1c1cdadc65f24c390170aa666015a2e8f7ec5c9d6a3875f",
apps/nextra/pages/en/build/aips/_meta.tsx:3
- [nitpick] The page title in the MDX uses a colon ("AIP-88: Block Epilogue Transactions"), but here it uses a hyphen. Consider aligning the title formats for consistency.
"aip-88": "AIP-88 - Block Epilogue Transactions",
grao1991
approved these changes
Jul 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm fmt?pnpm lint?