Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@gregnazario
Copy link
Collaborator

Description

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copilot AI review requested due to automatic review settings July 2, 2025 00:40
@gregnazario gregnazario requested a review from hariria as a code owner July 2, 2025 00:40
@vercel
Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 1:08am

This comment was marked as outdated.

@gregnazario gregnazario requested review from Copilot and grao1991 July 2, 2025 00:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the AIP-88 FAQ page for block epilogue transactions and registers it in the site metadata.

  • Introduce aip-88.mdx with detailed FAQ and example JSON output for the new Block Epilogue transaction
  • Update _meta.tsx to include the AIP-88 entry in the AIPs navigation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/nextra/pages/en/build/aips/aip-88.mdx Add Block Epilogue Transactions FAQ document for AIP-88
apps/nextra/pages/en/build/aips/_meta.tsx Register AIP-88 title in metadata mapping
Comments suppressed due to low confidence (2)

apps/nextra/pages/en/build/aips/aip-88.mdx:55

  • The JSON example includes the "state_checkpoint_hash" field, but the new Block Epilogue transaction may not include this field. Please confirm whether this should be present and update the example accordingly.
    "state_checkpoint_hash":"0x841a43956ca09a02b1c1cdadc65f24c390170aa666015a2e8f7ec5c9d6a3875f",

apps/nextra/pages/en/build/aips/_meta.tsx:3

  • [nitpick] The page title in the MDX uses a colon ("AIP-88: Block Epilogue Transactions"), but here it uses a hyphen. Consider aligning the title formats for consistency.
  "aip-88": "AIP-88 - Block Epilogue Transactions",

@gregnazario gregnazario enabled auto-merge (rebase) July 2, 2025 01:04
@gregnazario gregnazario merged commit 956063b into main Jul 2, 2025
5 of 6 checks passed
@gregnazario gregnazario deleted the add-more-aip-faqs branch July 2, 2025 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants