Skip to content

Add API endpoint suitable for dput.#1436

Open
benallard wants to merge 6 commits into
aptly-dev:masterfrom
benallard:dput_api
Open

Add API endpoint suitable for dput.#1436
benallard wants to merge 6 commits into
aptly-dev:masterfrom
benallard:dput_api

Conversation

@benallard

Copy link
Copy Markdown

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx

neolynx commented Apr 12, 2025

Copy link
Copy Markdown
Member

looks good !

could you please add a description for the PR, maybe with an example on how to use it?

In order to merge, we should add a system test and make sure we have good test coverage. Maybe you can have a look at existing tests, and copy and modify one...

the test seem to fail in the pipeline, due to a go version conflict. I will look at this soonish...

@neolynx

neolynx commented Apr 25, 2025

Copy link
Copy Markdown
Member

Hi and thanks a lot for this feature !

I tried to rebase on master, but don't have the permissions on your repo. could you somehow share the PR or rebase ?

The system tests should be working again on master...

@neolynx neolynx added the needs rebase The PR needs to be rebased on master label Apr 26, 2025
@neolynx neolynx added the help wanted ! Please help getting this PR merged :-) label May 25, 2025
@neolynx neolynx removed the needs rebase The PR needs to be rebased on master label Apr 27, 2026
@neolynx

neolynx commented Apr 27, 2026

Copy link
Copy Markdown
Member

rebased on master

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.84%. Comparing base (2974558) to head (cf57a85).

Files with missing lines Patch % Lines
api/files.go 39.28% 11 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
- Coverage   77.22%   76.84%   -0.38%     
==========================================
  Files         161      161              
  Lines       15085    15114      +29     
==========================================
- Hits        11649    11614      -35     
- Misses       2292     2354      +62     
- Partials     1144     1146       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neolynx neolynx added this to the 1.6.3 milestone May 2, 2026
@neolynx neolynx requested a review from a team June 4, 2026 18:31
@neolynx neolynx added needs review Ready for review & merge and removed help wanted ! Please help getting this PR merged :-) needs tests labels Jun 4, 2026
@neolynx

neolynx commented Jun 4, 2026

Copy link
Copy Markdown
Member

rebased, and added tests

wait for race cond PRs to me merged...

@neolynx neolynx force-pushed the dput_api branch 2 times, most recently from 5e44b2e to d193e22 Compare June 7, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Ready for review & merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants