fix: ts error in console sdk and add to tests

[ChiragAgg5k]

Summary by CodeRabbit

• Chores

  • Updated SDK build validation to add an additional web SDK build target.

• Refactor

  • Narrowed allowed types for dynamic client configuration keys.

• Bug Fixes

  • Removed legacy cookie-setting method from the CLI client API.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request makes three factual changes: (1) adds a second web SDK matrix entry in the GitHub Actions workflow with platform set to console, creating an additional build row; (2) narrows the dynamic index signature on Client.config in templates/web/src/client.ts.twig from string | boolean | undefined (for console) to string | undefined unconditionally; and (3) removes the public setCookie(cookie: string): this method from templates/cli/lib/client.ts.twig.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title refers to fixing a TypeScript error in the console SDK, which is directly supported by the changes to templates/web/src/client.ts.twig that narrow the config type signature. However, it omits the workflow matrix update and CLI method removal, making it incomplete for the full changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f70c437 and 243aec0.

📒 Files selected for processing (2)

• templates/cli/lib/client.ts.twig
• templates/web/src/client.ts.twig

💤 Files with no reviewable changes (1)

• templates/cli/lib/client.ts.twig

🚧 Files skipped from review as they are similar to previous changes (1)

• templates/web/src/client.ts.twig

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)

• GitHub Check: build (8.3, Python310)
• GitHub Check: build (8.3, Ruby27)
• GitHub Check: build (8.3, PHP83)
• GitHub Check: build (8.3, Go112)
• GitHub Check: build (8.3, PHP80)
• GitHub Check: build (8.3, Android14Java17)
• GitHub Check: build (8.3, Node18)
• GitHub Check: build (8.3, DotNet90)
• GitHub Check: build (8.3, DartBeta)
• GitHub Check: build (8.3, CLINode20)
• GitHub Check: build (8.3, KotlinJava8)
• GitHub Check: build (8.3, FlutterStable)
• GitHub Check: build (8.3, Android5Java17)
• GitHub Check: swift (server)
• GitHub Check: android (client)
• GitHub Check: apple (client)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

templates/web/src/client.ts.twig (1)

459-459: Consider explicit string conversion for type safety.

The type cast resolves the TypeScript error, but String() conversion would be more defensive if this.config.project is unexpectedly non-string:

-                channels.set('project', this.config.project as string);
+                channels.set('project', String(this.config.project));

This ensures URLSearchParams receives a string even if the config value is malformed.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4fae2f and f70c437.

📒 Files selected for processing (2)

• .github/workflows/sdk-build-validation.yml
• templates/web/src/client.ts.twig

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-12-18T18:42:20.227Z

Learnt from: ArnabChatterjee20k
Repo: appwrite/sdk-generator PR: 1266
File: templates/swift/Sources/WebSockets/WebSocketClient.swift.twig:140-140
Timestamp: 2025-12-18T18:42:20.227Z
Learning: In templates/swift/Sources/WebSockets/WebSocketClient.swift.twig, the Channel type from NIOCore is explicitly qualified as `NIOCore.Channel` to avoid naming conflicts with the new Channel helper class for realtime subscriptions. This is not a breaking change - it's the same type, just explicitly qualified in the source.

Applied to files:

• templates/web/src/client.ts.twig

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

• GitHub Check: build (8.3, KotlinJava17)
• GitHub Check: build (8.3, DotNet90)
• GitHub Check: build (8.3, AppleSwift56)
• GitHub Check: build (8.3, DartBeta)
• GitHub Check: build (8.3, Swift56)
• GitHub Check: build (8.3, FlutterStable)
• GitHub Check: build (8.3, PHP80)
• GitHub Check: build (8.3, Android14Java17)
• GitHub Check: build (8.3, Android5Java17)
• GitHub Check: swift (server)
• GitHub Check: android (client)
• GitHub Check: apple (client)

🔇 Additional comments (1)

.github/workflows/sdk-build-validation.yml (1)

64-66: LGTM! Console SDK now validated in CI.

Adding the web SDK with console platform to the build matrix ensures the TypeScript fix is validated during CI, preventing future regressions.