feat: support concurrent chunk uploads#75
Conversation
Greptile SummaryThis PR refactors the chunked upload paths in
Confidence Score: 4/5The concurrent upload machinery is functionally sound — handle cleanup, the multi-exec event loop, and upload-ID propagation all work correctly — but the three files are identical copies of non-trivial curl_multi code, and the split between the sequential first-chunk path and the concurrent path leaves duplicated request-building logic that could drift silently. The critical correctness issues from the previous review round (CURLM_CALL_MULTI_PERFORM handling, resource cleanup on exception) have been addressed. The remaining findings are maintenance concerns rather than runtime defects, but the volume of duplicated low-level networking code across three files means a subtle future mistake is more likely to go unnoticed. All three service files carry identical curl_multi logic; Functions.php and Sites.php also retain the now-unused $id variable from the old sequential loop. Important Files Changed
Reviews (2): Last reviewed commit: "feat: support concurrent chunk uploads" | Re-trigger Greptile |
This PR updates the SDK to support concurrent chunk uploads.