feat: PHP SDK 24.0.1 — nullable BillingLimits, consoleAccessedAt empty default#72
Closed
premtsd-code wants to merge 2 commits into
Closed
feat: PHP SDK 24.0.1 — nullable BillingLimits, consoleAccessedAt empty default#72premtsd-code wants to merge 2 commits into
premtsd-code wants to merge 2 commits into
Conversation
Greptile SummaryThis patch (SDK 24.0.1) fixes a runtime crash where every
Confidence Score: 5/5Safe to merge — targeted fix for a real parse crash and a clean rollback of an unreleased feature, with no remaining broken references. The billing-limits changes correctly address the parse failure without introducing new required fields or breaking the constructor API. All Presences-related symbols were fully removed with no dangling imports confirmed by codebase-wide search. Test fixtures updated consistently across 14 test cases. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "chore: bump version to 24.0.1 and add ch..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
39
to
42
| public static function from(array $data): static | ||
| { | ||
| if (!array_key_exists('bandwidth', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "bandwidth" for ' . static::class . '.'); | ||
| } | ||
| if (!array_key_exists('storage', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "storage" for ' . static::class . '.'); | ||
| } | ||
| if (!array_key_exists('users', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "users" for ' . static::class . '.'); | ||
| } | ||
| if (!array_key_exists('executions', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "executions" for ' . static::class . '.'); | ||
| } | ||
| if (!array_key_exists('GBHours', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "GBHours" for ' . static::class . '.'); | ||
| } | ||
| if (!array_key_exists('imageTransformations', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "imageTransformations" for ' . static::class . '.'); | ||
| } | ||
| if (!array_key_exists('authPhone', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "authPhone" for ' . static::class . '.'); | ||
| } | ||
| if (!array_key_exists('budgetLimit', $data)) { | ||
| throw new \InvalidArgumentException('Missing required field "budgetLimit" for ' . static::class . '.'); | ||
| } | ||
|
|
||
| return new static( |
There was a problem hiding this comment.
from() method body now opens with an empty line before return new static(, which is a leftover from the deletion.
Suggested change
| public static function from(array $data): static | |
| { | |
| if (!array_key_exists('bandwidth', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "bandwidth" for ' . static::class . '.'); | |
| } | |
| if (!array_key_exists('storage', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "storage" for ' . static::class . '.'); | |
| } | |
| if (!array_key_exists('users', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "users" for ' . static::class . '.'); | |
| } | |
| if (!array_key_exists('executions', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "executions" for ' . static::class . '.'); | |
| } | |
| if (!array_key_exists('GBHours', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "GBHours" for ' . static::class . '.'); | |
| } | |
| if (!array_key_exists('imageTransformations', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "imageTransformations" for ' . static::class . '.'); | |
| } | |
| if (!array_key_exists('authPhone', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "authPhone" for ' . static::class . '.'); | |
| } | |
| if (!array_key_exists('budgetLimit', $data)) { | |
| throw new \InvalidArgumentException('Missing required field "budgetLimit" for ' . static::class . '.'); | |
| } | |
| return new static( | |
| public static function from(array $data): static | |
| { | |
| return new static( |
premtsd-code
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the PHP SDK for version 24.0.1.