Skip to content

fix(publish): bump actions/upload-artifact to v4.6.2#317

Merged
ChiragAgg5k merged 1 commit into
masterfrom
dev
May 15, 2026
Merged

fix(publish): bump actions/upload-artifact to v4.6.2#317
ChiragAgg5k merged 1 commit into
masterfrom
dev

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented May 15, 2026

Re-release of 21.0.0 with the publish workflow fix from appwrite/sdk-generator 1.29.4.

The previous release pipeline failed on the unsigned-windows upload step (actions/upload-artifact@v4.2.4 is deprecated). This bumps the pinned SHA to v4.6.2.

Changes

  • .github/workflows/publish.yml: actions/upload-artifact SHA pin 0400d5f (v4.2.4) → ea165f8 (v4.6.2)

No version bump or changelog changes — same 21.0.0 release.

@ChiragAgg5k ChiragAgg5k changed the title feat: Command Line SDK update for version 21.0.0 fix(publish): bump actions/upload-artifact to v4.6.2 May 15, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 15, 2026

Greptile Summary

This PR updates the actions/upload-artifact action in the publish workflow from v4.2.4 (SHA-pinned) to v4.6.2 (SHA-pinned and verified). The new commit SHA correctly maps to the v4.6.2 tag.

  • The SHA ea165f8d65b6e75b540449e92b4886f43607fa02 is confirmed to match the v4.6.2 release on actions/upload-artifact.
  • v4.6.2 still runs on Node.js 20, which GitHub is forcing to Node.js 24 on June 2 2026 — v6 of the action is available and defaults to Node.js 24.

Confidence Score: 4/5

Safe to merge — this is a single-line action version bump with a verified SHA, and the workflow logic is unchanged.

The only change is bumping actions/upload-artifact from v4.2.4 to v4.6.2, and the new SHA correctly matches the tagged release. The one concern is that v4.6.2 still runs on Node.js 20, which GitHub is deprecating on June 2 2026, so this upgrade might need a follow-up soon.

.github/workflows/publish.yml — specifically whether v4.6.2 is the right stopping point given the impending Node.js 20 end-of-life on GitHub Actions.

Important Files Changed

Filename Overview
.github/workflows/publish.yml Bumps actions/upload-artifact from v4.2.4 to v4.6.2 (SHA verified); v4.6.2 still targets Node.js 20, which GitHub is forcing to Node.js 24 on June 2 2026

Reviews (1): Last reviewed commit: "chore: update Command Line SDK to 21.0.0" | Re-trigger Greptile

- name: Upload unsigned Windows binaries
id: upload-windows-unsigned
uses: actions/upload-artifact@0400d5f644dc74513175e3cd8d07132dd4860809 # v4.2.4
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 actions/upload-artifact@v4.6.2 runs on Node.js 20, which GitHub Actions is deprecating and will force to Node.js 24 starting June 2 2026 (in ~18 days from today). This will trigger deprecation warnings now and may cause failures after the cutover. v6 is the first release that defaults to Node.js 24 — consider upgrading directly to it to avoid this entirely.

Suggested change
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v6.1.0

@ChiragAgg5k ChiragAgg5k merged commit 81fbffd into master May 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants