Skip to content

Fix column update sheet missing column#3081

Merged
HarshMN2345 merged 2 commits into
mainfrom
fix-column-update-sheet-missing-column
Jun 8, 2026
Merged

Fix column update sheet missing column#3081
HarshMN2345 merged 2 commits into
mainfrom
fix-column-update-sheet-missing-column

Conversation

@HarshMN2345

Copy link
Copy Markdown
Member

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@HarshMN2345 HarshMN2345 force-pushed the fix-column-update-sheet-missing-column branch from f164ad5 to e9f3705 Compare June 8, 2026 13:35
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a bug where opening the "Update column" sheet left the column data empty because $databaseColumnSheetOptions.column was never assigned in the update action branch.

  • Adds $databaseColumnSheetOptions.column = column before show = true in the update branch, mirroring the pattern already used in the column-left/column-right branches.
  • Adds optional chaining (rowColumn?.type) for defensive null safety in the cell-rendering template; isTextType already guards against undefined inputs so the downstream 'encrypt' in rowColumn check remains safe.

Confidence Score: 5/5

Safe to merge — a minimal, targeted fix that corrects missing column data propagation in the edit sheet.

The change is a single-line addition to an existing action handler, consistent with the pattern already used for the column-left/column-right branches. The optional-chaining addition is guarded by isTextType's own null check, so there is no risk of regressions in the cell-rendering path.

No files require special attention.

Important Files Changed

Filename Overview
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte Adds the missing column assignment to the databaseColumnSheetOptions store before opening the edit sheet, fixing the empty-column bug; also adds optional chaining on rowColumn?.type as a defensive guard.

Reviews (3): Last reviewed commit: "fix stuck issue" | Re-trigger Greptile

@HarshMN2345 HarshMN2345 force-pushed the fix-column-update-sheet-missing-column branch from a070fce to 716a293 Compare June 8, 2026 13:45
@HarshMN2345 HarshMN2345 merged commit 05c1705 into main Jun 8, 2026
4 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-column-update-sheet-missing-column branch June 8, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants