Skip to content

Show warning when VCS integration is not authorized for auto-deployments #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hmacr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Show warning when VCS integration is not authorized for auto-deployments #2887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e3b03a
Show warning when VCS integration is not authorized for auto-deployments
hmacr Feb 26, 2026
de1ef99
another version
hmacr Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 53 additions & 11 deletions src/lib/components/git/deploymentSource.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,77 @@
<script lang="ts">
import { Trim } from '$lib/components';
import { Link } from '$lib/elements';
import { sdk } from '$lib/stores/sdk';
import type { Models } from '@appwrite.io/console';
import {
IconCode,
IconExclamation,
IconGitBranch,
IconGitCommit,
IconGithub,
IconTerminal
} from '@appwrite.io/pink-icons-svelte';
import { ActionMenu, Layout, Popover, Icon } from '@appwrite.io/pink-svelte';
import { ActionMenu, Layout, Popover, Icon, Tooltip } from '@appwrite.io/pink-svelte';
import { onMount } from 'svelte';

let {
deployment
deployment,
resource,
region,
project
}: {
deployment: Models.Deployment;
resource?: Models.Site | Models.Function;
region?: string;
project?: string;
} = $props();

let authorized = $state(null);
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning icon could flash in after page loads since authorized starts as null and updates asynchronously

Suggested change
let authorized = $state(null);
let authorized = $state<boolean | null>(null);


async function loadAuthorized() {
if (!resource?.installationId || !resource?.providerRepositoryId || !region || !project) {
return;
}

try {
const repository = await sdk.forProject(region, project).vcs.getRepository({
installationId: resource.installationId,
providerRepositoryId: resource.providerRepositoryId
});
authorized = repository.authorized;
} catch (err) {
console.warn(err);
}
}
Comment on lines +31 to +45
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetching repository data in onMount happens after page load, not in parallel with initial data loading - consider moving this to the page loaders (+page.ts) using Promise.all for true parallelization as mentioned in the PR description


onMount(() => {
loadAuthorized();
});
</script>

{#if deployment.type === 'vcs'}
<Popover padding="none" let:toggle>
<div>
<Link
on:click={(e) => {
e.preventDefault();
toggle(e);
}}>
<Layout.Stack direction="row" gap="xs" alignItems="center">
<Icon icon={IconGithub} size="s" /> GitHub
</Layout.Stack>
</Link>
<Layout.Stack direction="row" gap="xs" alignItems="center">
<Link
on:click={(e) => {
e.preventDefault();
toggle(e);
}}>
<Layout.Stack direction="row" gap="xs" alignItems="center">
<Icon icon={IconGithub} size="s" /> GitHub
</Layout.Stack>
</Link>
{#if authorized === false}
<Tooltip>
<Icon icon={IconExclamation} size="s" color="--bgcolor-warning" />
<span slot="tooltip">
Integration not authorized for auto deployments.<br />
To enable, add the repository to the installation settings.
</span>
</Tooltip>
{/if}
</Layout.Stack>
</div>
<svelte:fragment slot="tooltip">
<ActionMenu.Root>
Expand Down
6 changes: 5 additions & 1 deletion ...oject-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,11 @@
{@render titleSnippet('Source')}
<Typography.Text variant="m-400" color="--fgcolor-neutral-primary">
<div>
<DeploymentSource {deployment} />
<DeploymentSource
{deployment}
resource={$func}
region={page.params.region}
project={page.params.project} />
</div>
</Typography.Text>
</Layout.Stack>
Expand Down
8 changes: 7 additions & 1 deletion src/routes/(console)/project-[region]-[project]/sites/(components)/siteCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,14 @@
import type { Snippet } from 'svelte';

let {
site,
deployment,
proxyRuleList,
hideQRCode = false,
variant = 'primary',
footer
}: {
site: Models.Site;
deployment: Models.Deployment;
proxyRuleList: Models.ProxyRuleList;
hideQRCode?: boolean;
Expand Down Expand Up @@ -208,7 +210,11 @@
Source
</Typography.Text>
<Typography.Text variant="m-400" color="--fgcolor-neutral-primary">
<DeploymentSource {deployment} />
<DeploymentSource
{deployment}
resource={site}
region={page.params.region}
project={page.params.project} />
</Typography.Text>
</Layout.Stack>
</Layout.Stack>
Expand Down
5 changes: 4 additions & 1 deletion src/routes/(console)/project-[region]-[project]/sites/site-[site]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@
<Container>
<Layout.Stack gap="xxxl">
{#if data?.deployment && data.deployment.status === 'ready'}
<SiteCard deployment={data.deployment} proxyRuleList={data.proxyRuleList}>
<SiteCard
site={data.site}
deployment={data.deployment}
proxyRuleList={data.proxyRuleList}>
{#snippet footer()}
{#if data.proxyRuleList.total}
<Button
Expand Down
Loading