Skip to content

fix: domains searching#2883

Merged
HarshMN2345 merged 1 commit intomainfrom
fix-SER-1124-domains-searching
Feb 25, 2026
Merged

fix: domains searching#2883
HarshMN2345 merged 1 commit intomainfrom
fix-SER-1124-domains-searching

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Feb 25, 2026

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • New Features

    • Search parameter functionality implemented for domain filtering in the organization console.
  • Updates

    • Refined empty search state rendering to appropriately display results when search parameters or query conditions are active in domain listings.

@appwrite
Copy link

appwrite bot commented Feb 25, 2026

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Schedule functions to run as often as every minute with cron expressions

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a41047e and ceb2b40.

📒 Files selected for processing (2)
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.ts

Walkthrough

This pull request adds search functionality to a domain management page. The server-side load function was modified to pass an optional search parameter to the domains API call, and the client-side component's conditional rendering logic was updated to display the empty search state when either a query or search term exists, replacing the previous logic that only checked for query parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: domains searching' is directly related to the changeset, which adds search functionality to the domains page by introducing a search parameter.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-SER-1124-domains-searching

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

Fixed domain search functionality by passing the search parameter to the API call and updating the empty state condition to display when either filters (query) or search term (search) are active. Previously, searching for domains would not work because the search parameter wasn't being sent to the backend, and the empty search state would only show for filters, not for search queries.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are minimal, well-targeted, and follow established patterns used elsewhere in the codebase. The fix correctly addresses a bug where domain search functionality was broken due to missing search parameter handling.
  • No files require special attention

Important Files Changed

Filename Overview
src/routes/(console)/organization-[organization]/domains/+page.svelte Fixed empty search state to show when either query filters or search term is active
src/routes/(console)/organization-[organization]/domains/+page.ts Added search parameter to domains API call to enable search functionality

Last reviewed commit: ceb2b40

Copy link
Contributor

@hmacr hmacr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarshMN2345 HarshMN2345 merged commit 301caeb into main Feb 25, 2026
5 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-SER-1124-domains-searching branch February 25, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants