Skip to content

fix: bug #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 1 commit into from
Feb 13, 2026
+14 −2
Merged

fix: bug #2853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
"dayjs": "^1.11.13",
"deep-equal": "^2.2.3",
"echarts": "^5.6.0",
"https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@a4067bf": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@a4067bf",
"https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@a4067bf": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@a4067bf",
Comment on lines +41 to +42
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Malformed duplicate dependency entries — likely accidental.

Lines 25 and 27 already declare @appwrite.io/pink-icons-svelte and @appwrite.io/pink-svelte (at @df765cc). These new lines use the full URL as the package key, which is not a valid dependency identifier, and point to a different commit (@a4067bf). This looks like a lockfile artifact or accidental paste that will either be ignored, cause resolution conflicts, or shadow the existing entries.

If the intent is to upgrade, update the existing entries on lines 25 and 27 to the new commit hash instead.

Proposed fix 
-        "@appwrite.io/pink-icons-svelte": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@df765cc",
+        "@appwrite.io/pink-icons-svelte": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@a4067bf",
         "@appwrite.io/pink-legacy": "^1.0.3",
-        "@appwrite.io/pink-svelte": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@df765cc",
+        "@appwrite.io/pink-svelte": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@a4067bf",
         ...
-        "https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@a4067bf": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@a4067bf",
-        "https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@a4067bf": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@a4067bf",
🤖 Prompt for AI Agents 
In `@package.json` around lines 41 - 42, Remove the malformed dependency entries
where the package key is the full URL
("https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@a4067bf" and
"https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@a4067bf") and either delete
them or replace them by updating the existing dependency declarations for
`@appwrite.io/pink-icons-svelte` and `@appwrite.io/pink-svelte` to the intended
commit/hash (if you meant to upgrade to `@a4067bf`) so the dependency keys remain
the valid package names (`@appwrite.io/pink-icons-svelte`,
`@appwrite.io/pink-svelte`) rather than full URLs.

"ignore": "^6.0.2",
"nanoid": "^5.1.5",
"nanotar": "^0.1.1",
Expand Down
12 changes: 11 additions & 1 deletion src/lib/elements/forms/inputNumber.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,17 @@
export let leadingIcon: ComponentType | undefined = undefined;

let error: string;

// TODO: Remove this once Pink Svelte is fixed
$: if (value !== null && typeof value === 'object' && 'target' in (value as object)) {
const event = value as Event;
const target = event.target as HTMLInputElement;
if (target?.value !== undefined) {
const parsedValue = target.value === '' ? null : Number(target.value);
value = Number.isNaN(parsedValue) ? null : parsedValue;
} else {
value = null;
}
}
Comment on lines +22 to +32
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if there's an existing issue referencing this workaround or the pink-svelte input event bug
rg -rn "pink" -i --type=svelte || true
rg -rn "TODO.*Pink" -i || true
# Also check for any github/issue links in the codebase related to svelte input
rg -rn "github.*issue\|#[0-9]+.*pink\|pink.*#[0-9]+" -i || true

Repository: appwrite/console

Length of output: 50422

🏁 Script executed:

#!/bin/bash
# Read the inputNumber.svelte file to see the exact TODO
head -40 src/lib/elements/forms/inputNumber.svelte | cat -n

# Also check for any issue references in the file
grep -i "issue\|github\|#[0-9]\|bug\|pink" src/lib/elements/forms/inputNumber.svelte || echo "No issue references found"

Repository: appwrite/console

Length of output: 1920

🏁 Script executed:

#!/bin/bash
# Check for any references to Pink Svelte issues or GitHub in the repo
find . -type f \( -name "*.md" -o -name ".github" -o -name "*.json" \) 2>/dev/null | head -20

# Search for any GitHub issues or Pink Svelte issue tracking
rg -i "pink.?svelte.*issue|pink.?svelte.*github|appwrite.*pink" --max-count=20 || echo "No GitHub references found"

# Check if there's a package.json or dependency file that might reference Pink Svelte version
rg "pink-svelte" -A2 -B2 || echo "No package references"
</parameter>

Repository: appwrite/console

Length of output: 50498

🏁 Script executed:

#!/bin/bash
# Check for any comment with issue/bug references near the TODO
grep -B5 -A10 "TODO.*Pink Svelte" src/lib/elements/forms/inputNumber.svelte

# Check if there are any issue references in common places
grep -r "pink-svelte" .github 2>/dev/null || echo "No .github references"

# Check the package.json to understand the Pink Svelte version/status
grep -A2 -B2 "pink-svelte" package.json | head -10

Repository: appwrite/console

Length of output: 1429

Reference the upstream Pink Svelte issue in the TODO comment.

The TODO comment lacks a link to a tracked upstream issue. Without this reference, the workaround on lines 23-32 may become permanent. Add the GitHub issue URL (or issue tracker link) to the comment so it's clear what needs to be resolved before this code can be removed.

For example:

// TODO: Remove this once Pink Svelte is fixed
// See: https://github.com/appwrite/pink-svelte/issues/<number>
🤖 Prompt for AI Agents 
In `@src/lib/elements/forms/inputNumber.svelte` around lines 22 - 32, Update the
TODO above the reactive block that handles synthetic event objects (the $:
reactive statement referencing value and casting to Event and HTMLInputElement)
to include the upstream Pink Svelte issue tracker link so it's clear when the
workaround can be removed; modify the comment that currently reads "// TODO:
Remove this once Pink Svelte is fixed" to add a "See:
https://github.com/appwrite/pink-svelte/issues/<number>" (or equivalent issue
URL) immediately below it, so the reactive block (the value handling logic) is
traceable to the upstream issue.

const handleInvalid = (event: Event & { currentTarget: EventTarget & HTMLInputElement }) => {
event.preventDefault();

Expand Down