Abstract API: add server transport capability request option#146
Open
nakulbajaj wants to merge 5 commits into
Open
Abstract API: add server transport capability request option#146nakulbajaj wants to merge 5 commits into
nakulbajaj wants to merge 5 commits into
Conversation
FranzBusch
reviewed
Apr 27, 2026
| /// | ||
| /// ``HTTPVersion`` provides type-safe access to supported HTTP protocol versions, | ||
| /// allowing clients and servers to communicate version capabilities. | ||
| public enum HTTPVersion: UInt8, Sendable, Hashable { |
Member
There was a problem hiding this comment.
Suggested change
| public enum HTTPVersion: UInt8, Sendable, Hashable { | |
| @nonexhaustive | |
| public enum HTTPVersion: UInt8, Sendable, Hashable { |
| /// Providing server HTTP version information allows the client to optimize | ||
| /// connection establishment. For example, if a server is known to support HTTP/3, | ||
| /// the client can attempt a QUIC connection directly. | ||
| public protocol ServerHTTPVersionCapability: RequestOptions { |
Member
There was a problem hiding this comment.
Can we include "Hint" in the name here
nakulbajaj
force-pushed
the
request-options-server-http-version
branch
from
6746279 to
8a363cf
Compare
nakulbajaj
changed the title
guoye-zhang
reviewed
May 16, 2026
| case tcp | ||
|
|
||
| /// TCP with TLS transport. | ||
| case tcpWithTLS |
Collaborator
There was a problem hiding this comment.
I think we don't need this case since whether the server supports TLS is already known to the user when they put http or https in the URL.
| /// capabilities. New transports may be added in future releases, so client | ||
| /// code must handle unknown cases. | ||
| @nonexhaustive | ||
| public enum TransportVersion: Sendable, Hashable { |
Collaborator
There was a problem hiding this comment.
Let's name it HTTPTransportProtocol since this is specific to HTTP
| public var allowsExpensiveNetworkAccess: Bool = true | ||
| public var allowsConstrainedNetworkAccess: Bool = true | ||
| public var assumesHTTP3Capable: Bool = false | ||
| public var serverSupportedTransports: Set<TransportVersion> = [] |
Collaborator
There was a problem hiding this comment.
We should default it to [.tcp], maybe call it a hint in the property name as well?
Member
Author
There was a problem hiding this comment.
Updated to serverSupportedTransportsHint and the protocol name to just ServerTransportHint, I realized it doesn't need Capability in the name
guoye-zhang
approved these changes
May 18, 2026
guoye-zhang
reviewed
May 19, 2026
| public struct RequestOptions: HTTPClientCapability.RequestOptions { | ||
|
|
||
| public struct RequestOptions: HTTPClientCapability.ServerTransportHint { | ||
| public var serverSupportedTransportsHint: Set<NetworkTypes.HTTPTransportVersion> = [] |
Collaborator
There was a problem hiding this comment.
Should AHC conform or should we keep it to URLSession? Also let's make this .tcp by default as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.