Skip to content

Fix missing apostrophes in Image scope-walk comment#741

Open
LeSingh1 wants to merge 1 commit into
apple:mainfrom
LeSingh1:fix-image-comment-grammar
Open

Fix missing apostrophes in Image scope-walk comment#741
LeSingh1 wants to merge 1 commit into
apple:mainfrom
LeSingh1:fix-image-comment-grammar

Conversation

@LeSingh1
Copy link
Copy Markdown

Summary

Two contractions in Sources/Containerization/Image/Image.swift:111 (the skip branch of the manifest scope walk):

  • Its safeIt's safe
  • it wont haveit won't have

Test plan

  • swiftc -parse Sources/Containerization/Image/Image.swift — exit 0.

Scope

Comment text only. No code, behavior, or API changes.

@jglogan
Copy link
Copy Markdown
Contributor

jglogan commented May 18, 2026

@LeSingh1 thank you for the contribution.

For this to be merged, you need to configure commit signing - see https://github.com/apple/containerization/blob/main/CONTRIBUTING.md#pull-requests.

Two contractions in the manifest-scan skip path of pruneUnreferencedManifests:
'Its safe' → 'It's safe' and 'it wont have' → 'it won't have'.

Comment text only.
@LeSingh1 LeSingh1 force-pushed the fix-image-comment-grammar branch from 6473fc3 to ae26a9c Compare May 18, 2026 20:35
@LeSingh1
Copy link
Copy Markdown
Author

Thanks for the review! Configured SSH commit signing and force-pushed the resigned commit (ae26a9c). GitHub shows it as verified now — ready for another look when you have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants