Add a guard against an empty range in the EXT4 formatter#641
Merged
wlan0 merged 2 commits intoapple:mainfrom Apr 4, 2026
Merged
Add a guard against an empty range in the EXT4 formatter#641wlan0 merged 2 commits intoapple:mainfrom
wlan0 merged 2 commits intoapple:mainfrom
Conversation
Contributor
|
I agree that this loop would need guarding if the lower bound could exceed the upper bound, but with the current math I can’t find a reachable state where that happens. Can you add a failing regression test or share the exact formatter input that makes |
Contributor
Author
|
@wlan0 Added a test reproducing the crash. However, to reproduce the crash, I had to remove reserved blocks in |
wlan0
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a guard against an empty range in the EXT4 formatter to prevent a possible crash: