Skip to content

Conversation

@claudeaceae
Copy link
Contributor

Summary

  • Fixes a grammar error in the local Containerization development instructions

Details

Line 61 of BUILDING.md had "configure use your local" which should be "configure to use your local".

This is a simple grammar fix to improve readability.

Test plan

  • Verified the sentence now reads correctly

Changed 'configure use your local' to 'configure to use your local'
to correct the grammar in step 4 of the local Containerization
development instructions.
BUILDING.md Outdated
```

4. Use the Swift package manager to configure use your local `containerization` package and update your `Package.resolved` file.
4. Use the Swift package manager to configure to use your local `containerization` package and update your `Package.resolved` file.
Copy link
Contributor

@jglogan jglogan Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let get rid of the redundant use of "use" as well. How about?

Suggested change
4. Use the Swift package manager to configure to use your local `containerization` package and update your `Package.resolved` file.
4. Reconfigure the project to use your local `containerization` package and update your `Package.resolved` file.

Co-authored-by: jglogan <1019924+jglogan@users.noreply.github.com>
@claudeaceae
Copy link
Contributor Author

Good catch @jglogan! Applied your suggestion - reads much better now. Thanks for the review!

1 similar comment
@claudeaceae
Copy link
Contributor Author

Good catch @jglogan! Applied your suggestion - reads much better now. Thanks for the review!

@jglogan
Copy link
Contributor

jglogan commented Jan 2, 2026

@claudeaceae It looks like we've hit a snag in how we do our license header stuff for the CI builds - GH appears to be merging your PR to main prior to build, which causes license header checks to fail due to the year change (the checks want to see 2025-2026 for files which have only 2025).

I hit this with #1007 and rebase my change to main and run make fmt to get all the headers correct. Until we can get a fix in place for this glitch, you'll need to either merge/rebase main and do the same.

@jglogan
Copy link
Contributor

jglogan commented Jan 2, 2026

This is what we're currently seeing in the format checks for this PR.

Run ./scripts/install-hawkeye.sh
  ./scripts/install-hawkeye.sh
  make fmt
  
  if ! git diff --quiet -- . ; then
    echo "❌ The following files require formatting or license header updates:"
    git diff --name-only -- .
    false
  fi
  shell: /bin/bash -e {0}
Installing hawkeye
downloading hawkeye 6.1.0 aarch64-apple-darwin
installing to .local/bin
  hawkeye
everything's installed!
Applying the standard code formatting...
Updating license headers...
Checking existence of hawkeye...
hawkeye found!
2026-01-02T02:01:30.556296+00:00[GMT]  INFO hawkeye_fmt::git: git.rs:53 git config is resolved to enabled
2026-01-02T02:01:30.578116+00:00[GMT]  WARN hawkeye_fmt::processor: processor.rs:89 default mapping Extension { pattern: "h", header_type: "SLASHSTAR_STYLE" } is override by Extension { pattern: "h", header_type: "SWIFT_STYLE" }
2026-01-02T02:01:30.578141+00:00[GMT]  WARN hawkeye_fmt::processor: processor.rs:89 default mapping Extension { pattern: "c", header_type: "SLASHSTAR_STYLE" } is override by Extension { pattern: "c", header_type: "SWIFT_STYLE" }
2026-01-02T02:01:30.698030+00:00[GMT]  INFO hawkeye::subcommand: subcommand.rs:178 Updated header for files (dryRun=false): ["/Users/runner/actions-runner/_work/container/container/Sources/Services/ContainerAPIService/Containers/ContainersService.swift=replaced", "/Users/runner/actions-runner/_work/container/container/Sources/Services/ContainerSandboxService/SandboxService.swift=replaced"]
2026-01-02T02:01:30.698042+00:00[GMT]  INFO hawkeye::subcommand: subcommand.rs:188 All files have proper header.
❌ The following files require formatting or license header updates:
Sources/Services/ContainerAPIService/Containers/ContainersService.swift
Sources/Services/ContainerSandboxService/SandboxService.swift
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants