Fix port validation to allow same port for different protocols (#992) #1000
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iko1
force-pushed
the
fix/handle-overlapping-ports-different-protocols
branch
from
627dc96 to
cdf10b1
Compare
dcantah
reviewed
Jan 1, 2026
| @Test | ||
| func testPublishPortsSamePortDifferentProtocols() throws { | ||
| let result = try Parser.publishPorts([ | ||
| "8080:8080/tcp", |
Contributor
There was a problem hiding this comment.
Can you add a test case where the protocol isn't chosen so we can verify the default (tcp)? e.g.
"8081:8081",
"8081:8081/udp"
Contributor
|
@iko1 Can you fix the build issues? |
Contributor
Author
I don't think the current build issue is related to my change. |
iko1
force-pushed
the
fix/handle-overlapping-ports-different-protocols
branch
from
5a8d8ce to
d085d67
Compare
Contributor
|
@iko1 it's definitely not you. There's some weirdness in the OSS header checks due to the new year, and to the CI builds merging PRs against main before the header checks. |
jglogan
approved these changes
Jan 3, 2026
jglogan
approved these changes
Jan 3, 2026
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
lgtm, thank you for the fix!
Contributor
|
@iko1 it looks like you might need to push this again such that all commits have verified signatures |
iko1
force-pushed
the
fix/handle-overlapping-ports-different-protocols
branch
2 times, most recently
from
d085d67 to
4d3c396
Compare
iko1
force-pushed
the
fix/handle-overlapping-ports-different-protocols
branch
from
4d3c396 to
5112162
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes: #992
Port validation previously rejected valid configurations when the same port number was used for different protocols (TCP and UDP). For example:
-p 1024:1024/udp -p 1024:1024/tcpAlthough this is a valid and common use case, the validation logic treated it as a conflict.
To fix this, I updated the validation key to include the protocol name. The validation now checks for overlapping port numbers only within the same protocol, rather than across all protocols.
This change enables binding the same port number for both TCP and UDP, aligning the validation behavior with real-world networking requirements.
Testing