[OWNER-54] Make Feature Banner Optionally Dismissable #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appf-mike
force-pushed
the
make-feature-banner-optionally-dismissable
branch
from
28b353f to
0a32544
Compare
appf-mike
force-pushed
the
make-feature-banner-optionally-dismissable
branch
from
0a32544 to
33a999d
Compare
appf-mike
force-pushed
the
make-feature-banner-optionally-dismissable
branch
from
33a999d to
c1830e1
Compare
appf-mike
force-pushed
the
make-feature-banner-optionally-dismissable
branch
from
c1830e1 to
24cb79d
Compare
appf-mike
force-pushed
the
make-feature-banner-optionally-dismissable
branch
from
24cb79d to
a48b85a
Compare
JeremyRH
approved these changes
Dec 18, 2025
Contributor
|
Released prerelease version |
cshaffer
approved these changes
Dec 18, 2025
Contributor
Author
|
Ok I tested this both for its use in react-apm via storybook there, and for its eventual use in oportal locally. I also tested with the dismissable prop unset so it does not break existing implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.