Call onSelect when items are unselected after being hidden by filter #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://appfolio.atlassian.net/browse/AT-1097 |
crgb0s
changed the title
crgb0s
force-pushed
the
AT-1097-bank-accounts-deselected
branch
from
3fde97d to
b9fc49b
Compare
crgb0s
force-pushed
the
AT-1097-bank-accounts-deselected
branch
from
b9fc49b to
fff0a2a
Compare
JeremyRH
approved these changes
Nov 17, 2025
roomonthebroom
approved these changes
Nov 18, 2025
src/components/List/List.spec.js
Outdated
Comment on lines
476
to
477
| // Remove one of the selected items | ||
| component.setProps({ items: [itemObjs[1], itemObjs[2]] }); |
Contributor
There was a problem hiding this comment.
this is also adding a new item, yeah? mostly a nitpick about the comment
Contributor
Author
There was a problem hiding this comment.
Updated comment for clarity
This component will visually uncheck items when they are no longer visible after a search, but does not call the onSelect to update the selected state observed by parent context. This change keeps the visual state of the List in sync with the selected state of the parent.
crgb0s
force-pushed
the
AT-1097-bank-accounts-deselected
branch
from
fff0a2a to
5529b3c
Compare
JeremyRH
approved these changes
Nov 18, 2025
Contributor
|
Released prerelease version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component will visually uncheck items when they are no longer visible after a search, but does not call the onSelect to update the selected state observed by parent context. This change keeps the visual state of the List in sync with the selected state of the parent.