Skip to content

fix/ADFA-1123 Better error message for missing assets zip #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidschachterADFA merged 4 commits into from
Apr 6, 2026
+4 −2
Merged

fix/ADFA-1123 Better error message for missing assets zip #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e1a3db
fix/ADFA-1123 Better error message for missing assets zip
jomen-adfa Apr 6, 2026
7e1bbb8
address possible empty flash error message
jomen-adfa Apr 6, 2026
15f3c42
format change
jomen-adfa Apr 6, 2026
a394857
Merge branch 'stage' into fix/ADFA-1123-no-assets-zip
davidschachterADFA Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import org.adfa.constants.LOCAL_MAVEN_REPO_ARCHIVE_ZIP_NAME
import org.adfa.constants.TEMPLATE_CORE_ARCHIVE
import org.slf4j.LoggerFactory
import com.itsaky.androidide.resources.R
import com.itsaky.androidide.utils.flashError
import java.io.File
import java.io.FileNotFoundException
import java.io.IOException
Expand Down Expand Up @@ -131,7 +132,7 @@ object AssetsInstallationHelper {
true
} catch (e: FileNotFoundException) {
logger.error("ZIP file not found: {}", e.message)
onProgress(Progress("${e.message}"))
flashError("File not found - ${e.message}")
false
} catch (e: ZipException) {
logger.error("Invalid ZIP format: {}", e.message)
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/itsaky/androidide/assets/SplitAssetsInstaller.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ data object SplitAssetsInstaller : BaseAssetsInstaller() {
): Unit =
withContext(Dispatchers.IO) {
if (!Environment.SPLIT_ASSETS_ZIP.exists()) {
throw FileNotFoundException("Assets zip file not found at path: ${Environment.SPLIT_ASSETS_ZIP.path}")
throw FileNotFoundException("Assets zip file not found at path: ${Environment.SPLIT_ASSETS_ZIP.path}." +
" Please check Slack #qa-testing-builds channel for the latest version.")
}

zipFile = ZipFile(Environment.SPLIT_ASSETS_ZIP)
Expand Down
Loading