Conversation
📝 WalkthroughWalkthroughThe Maven project version property is updated from 2.5.0-SNAPSHOT to 2.5.0 in pom.xml, marking the transition from a development snapshot to a release version. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
============================================
+ Coverage 68.68% 70.96% +2.28%
- Complexity 1503 1632 +129
============================================
Files 212 224 +12
Lines 6396 6727 +331
Branches 647 679 +32
============================================
+ Hits 4393 4774 +381
+ Misses 1673 1601 -72
- Partials 330 352 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pom.xml`:
- Line 63: CHANGES.md is missing entries for the 2.5.0 release referenced by the
<revision>2.5.0</revision> bump; add one or more Markdown-formatted entries for
this release in CHANGES.md where each entry's link text is the change
description and the link target is the PR URL (not the issue URL), e.g. "[Fix
... detailed summary](https://github.com/.../pull/NNN)"; follow the AGENTS.md
convention and include all PRs/changes that went into 2.5.0, then mark the
"Update CHANGES log" checklist item as done in the contributor checklist.
|
|
||
| <properties> | ||
| <revision>2.5.0-SNAPSHOT</revision> | ||
| <revision>2.5.0</revision> |
There was a problem hiding this comment.
CHANGES.md not updated before release.
The contributor checklist explicitly marks "Update CHANGES log" as unchecked. Per project convention, every entry should be a Markdown link whose text is the change description and whose target is the PR URL (not the issue URL), e.g.:
[Fix ... detailed summary](https://github.com/apolloconfig/apollo-java/pull/130)
Please add the 2.5.0 release entries before merging. Based on learnings from AGENTS.md: "Format CHANGES.md entries as Markdown links with link text as change description and link target as PR URL."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pom.xml` at line 63, CHANGES.md is missing entries for the 2.5.0 release
referenced by the <revision>2.5.0</revision> bump; add one or more
Markdown-formatted entries for this release in CHANGES.md where each entry's
link text is the change description and the link target is the PR URL (not the
issue URL), e.g. "[Fix ... detailed summary](https://github.com/.../pull/NNN)";
follow the AGENTS.md convention and include all PRs/changes that went into
2.5.0, then mark the "Update CHANGES log" checklist item as done in the
contributor checklist.
What's the purpose of this PR
Prepare Apollo Java 2.5.0 release by removing
-SNAPSHOTfrom root revision.Which issue(s) this PR fixes:
Fixes #N/A (release task)
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit