fix: bump BrowserPool default operation_timeout to 60 seconds#1877
Open
fix: bump BrowserPool default operation_timeout to 60 seconds#1877
BrowserPool default operation_timeout to 60 seconds#1877Conversation
The previous 15s default was too tight for chromium cold-start on slow runners (Windows CI with Python 3.14 has been flaking out), causing spurious `TimeoutError: Creating a new page with plugin ... timed out.`
vdusek
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 92.57% 92.53% -0.04%
==========================================
Files 158 158
Lines 11078 11078
==========================================
- Hits 10255 10251 -4
- Misses 823 827 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous 15s default of
BrowserPool.operation_timeoutwas too tight for chromium cold-start on slow runners. Windows CI with Python 3.14 has been flaking out with:Bumping the default to 60s gives chromium enough headroom on slow machines without changing behavior for users who already pass an explicit
operation_timeout. Same value used in the existing precedent fix fortest_with_default_plugin_constructor(PR #1806).Failing CI run: https://github.com/apify/crawlee-python/actions/runs/25332581547/job/74269691220?pr=1869