Conversation
github-actions
bot
added
t-tooling
Pijukatel
force-pushed
the
remove-request-id
branch
from
28a3309 to
9d37e14
Compare
Pijukatel
commented
Aug 20, 2025
Pijukatel
commented
Aug 20, 2025
vdusek
reviewed
Aug 20, 2025
Contributor
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
This looks good, let's wait for the downstream repo PRs.
Member
|
this doesnt sound much like a feature to me 🙃 i'd call it a fix or a refactor |
Update leftover id-based variable names
Pijukatel
force-pushed
the
remove-request-id
branch
from
d8f5469 to
caf9e23
Compare
Pijukatel
force-pushed
the
remove-request-id
branch
from
434ab5b to
4fa7359
Compare
Contributor
Author
|
Failing docs are unrelated to this change. See apify/apify-docs#1822 (comment) |
vdusek
changed the title
request.idRequest.id field
vdusek
reviewed
Aug 22, 2025
vdusek
approved these changes
Aug 22, 2025
Contributor
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
1 comment, otherwise, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
request.idand replace all usages ofidwithunique_keyunique_keytoidand use it when calling id-based client methodsRequest.idfield crawlee-python#1366Issues
request.idcrawlee-python#1358