Skip to content

chore: Send Booleans as true or false to API#673

Open
Pijukatel wants to merge 1 commit intomasterfrom
send-booleans
Open

chore: Send Booleans as true or false to API#673
Pijukatel wants to merge 1 commit intomasterfrom
send-booleans

Conversation

@Pijukatel
Copy link
Contributor

Sending 1 and 0 is working, but is undocumented in the OpenAPI specification.
Spec defines booleans, JS client as well https://github.com/apify/apify-client-js/blob/v2.22.2/src/utils.ts

(sending 1 and 0 is working, but undocumented. Spec defines booleans, JS client as well)
@github-actions github-actions bot added this to the 136th sprint - Tooling team milestone Mar 16, 2026
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (5b57ff3) to head (bec3e53).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   94.75%   94.82%   +0.06%     
==========================================
  Files          45       45              
  Lines        4404     4404              
==========================================
+ Hits         4173     4176       +3     
+ Misses        231      228       -3     
Flag Coverage Δ
integration 94.82% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a fix? Also, there are tests failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants