feat: use DateTime abstraction from apalis-sql
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himmelschmidt
changed the title
DateTime abstraction from apalis-sql
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
@Himmelschmidt Did you run tests locally? I think you are basing your HEAD an old version and need to rebase |
Contributor
Author
I have run the tests and aside from the doctest there were no failures. I didn't fix it before, figured it might be out of scope, fixed it now. But I don't think that's what you were talking about |
Member
But the previous doctests passed, what changed? |
Member
|
Contributor
Author
Wasn't there a new If you'd like, i can delete this one and start fresh from HEAD to get a clean commit history |
Member
|
I think it should be ok, but it’s important to watch out for regressions.
Maybe just stash your changes then pull the latest, then pop those changes
and push.
…On Thu, 8 Jan 2026 at 19:18, Himmelschmidt ***@***.***> wrote:
*Himmelschmidt* left a comment (apalis-dev/apalis-sqlite#30)
<#30 (comment)>
I didn't fix it before, figured it might be out of scope, fixed it now.
But the previous doctests passed, what changed?
Wasn't there a new TaskBuilderExt added? I believe it was added in rc1
and when I started this PR, the apalis deps were still pointing at beta 1
(iirc).
If you'd like, i can delete this one and start fresh from HEAD to get a
clean commit history
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWXVRGXGBNUVKX3MS4U26RL4FZ7O3AVCNFSM6AAAAACQCH5OV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMRUGYZDGMJWHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
|
Regarding signing commits, I think you need to rebase all of the commits.
Or squash them into one signed commit.
On Thu, 8 Jan 2026 at 22:13, Geoffrey Mureithi ***@***.***>
wrote:
… I think it should be ok, but it’s important to watch out for regressions.
Maybe just stash your changes then pull the latest, then pop those changes
and push.
On Thu, 8 Jan 2026 at 19:18, Himmelschmidt ***@***.***>
wrote:
> *Himmelschmidt* left a comment (apalis-dev/apalis-sqlite#30)
> <#30 (comment)>
>
> I didn't fix it before, figured it might be out of scope, fixed it now.
>
> But the previous doctests passed, what changed?
>
> Wasn't there a new TaskBuilderExt added? I believe it was added in rc1
> and when I started this PR, the apalis deps were still pointing at beta 1
> (iirc).
>
> If you'd like, i can delete this one and start fresh from HEAD to get a
> clean commit history
>
> —
> Reply to this email directly, view it on GitHub
> <#30 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWXVRGXGBNUVKX3MS4U26RL4FZ7O3AVCNFSM6AAAAACQCH5OV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMRUGYZDGMJWHA>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
Replace direct chrono dependency with DateTime/DateTimeExt from apalis-sql, enabling support for both chrono and time datetime libraries via feature flags. Changes: - Add `chrono` (default) and `time` feature flags - Use DateTimeExt::from_unix_timestamp instead of chrono::Utc.timestamp_opt - Update apalis dependencies to 0.7.0-rc.2 - Move chrono to dev-dependencies (only needed for tests/examples) Related: apalis-dev/apalis#655
Himmelschmidt
force-pushed
the
feat/update-apalis-sql-imports
branch
from
962de03 to
2ecb4ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
DateTimeandDateTimeExtfrom apalis-sql instead of direct chrono dependency.Adds
chronoandtimefeature flags for datetime library selection.Related: apalis-dev/apalis#655