feat: use DateTime abstraction from apalis-sql
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add chrono/time feature flags for datetime library selection - Replace direct chrono usage with SqlDateTime and SqlDateTimeExt - Remove hardcoded chrono dependency in favor of feature-gated support - Update to apalis-sql path dependency for datetime abstraction Related to apalis-dev/apalis#655
Himmelschmidt
changed the title
Himmelschmidt
changed the title
|
Is this issue closed? |
Member
|
I am OOO till Monday, will look at it on the 5th.
…On Sat, 3 Jan 2026, 11:58 holmofy, ***@***.***> wrote:
*holmofy* left a comment (apalis-dev/apalis-postgres#39)
<#39 (comment)>
Is this issue closed?
—
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWXVRGVZHZX2XECIZMO2A5T4E6AB7AVCNFSM6AAAAACQCH3YJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMBWHEYDMNJSGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Himmelschmidt
changed the title
DateTime abstraction from apalis-sql
geofmureithi
requested changes
Jan 7, 2026
Member
geofmureithi
left a comment
geofmureithi
left a comment
There was a problem hiding this comment.
I have requested some minor changes, and these possibly apply to the other sql backends
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
geofmureithi
reviewed
Jan 7, 2026
geofmureithi
approved these changes
Jan 8, 2026
geofmureithi
approved these changes
Jan 8, 2026
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
DateTimeandDateTimeExtfrom apalis-sql instead of direct chrono dependency.Adds
chronoandtimefeature flags for datetime library selection.Related to apalis-dev/apalis#655