Skip to content

ZOOKEEPER-5047: Make PrometheusMetricsProvider KeyStore type detection consistent#2385

Merged
anmolnar merged 3 commits into
apache:masterfrom
PDavid:ZOOKEEPER-5047-PrometheusMetricsProvider-KeyStore-type
May 13, 2026
Merged

ZOOKEEPER-5047: Make PrometheusMetricsProvider KeyStore type detection consistent#2385
anmolnar merged 3 commits into
apache:masterfrom
PDavid:ZOOKEEPER-5047-PrometheusMetricsProvider-KeyStore-type

Conversation

@PDavid
Copy link
Copy Markdown
Contributor

@PDavid PDavid commented May 13, 2026

Load KeyStore / TrustStore in PrometheusMetricsProvider as in JettyAdminServer to benefit from the same behavior, mainly KeyStore / TrustStore type detection.

PDavid added 2 commits May 13, 2026 09:49
…n consistent

Load KeyStore / TrustStore in PrometheusMetricsProvider as in JettyAdminServer to benefit from the same behavior, mainly KeyStore / TrustStore type detection.
…yStore / TrustStore type

to reflect latest state.
@PDavid PDavid marked this pull request as ready for review May 13, 2026 07:57
Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. lgtm.

@anmolnar anmolnar merged commit ed28ce7 into apache:master May 13, 2026
16 checks passed
@anmolnar
Copy link
Copy Markdown
Contributor

Merged to master branch. Thanks @PDavid !

@PDavid PDavid deleted the ZOOKEEPER-5047-PrometheusMetricsProvider-KeyStore-type branch May 13, 2026 19:24
@PDavid
Copy link
Copy Markdown
Contributor Author

PDavid commented May 13, 2026

Many thanks for the reviews and the merge! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants