[ZEPPELIN-6398] Fix Selenium-based integration tests#5160
Merged
tbonelee merged 5 commits intoapache:masterfrom Feb 25, 2026
Merged
[ZEPPELIN-6398] Fix Selenium-based integration tests#5160tbonelee merged 5 commits intoapache:masterfrom
tbonelee merged 5 commits intoapache:masterfrom
Conversation
…hes on Linux with xvfb.
Replace FluentWait with WebDriverWait using visibilityOfElementLocated to prevent ElementNotInteractableException when modal animations have not yet completed.
…arRunParagraph timeout The previous commit replaced FluentWait with visibilityOfElementLocated for all cases, but this caused timeouts for dynamically rendered Angular elements that may exist in DOM but are not yet visible. Split into three methods: - pollingWait: presenceOfElementLocated (DOM existence only) - visibilityWait: visibilityOfElementLocated (visible + has dimensions) - clickableWait: elementToBeClickable (visible + enabled for interaction)
Reamer
approved these changes
Feb 23, 2026
Contributor
Reamer
left a comment
Reamer
left a comment
There was a problem hiding this comment.
LGTM
I like that testing with Chromium is happening again.
tbonelee
added a commit
that referenced
this pull request
Feb 25, 2026
### What is this PR for? Selenium-based integration tests have been failing recently. There were several issues: - The Chrome/Edge driver had a bug related to calling window.maximize(). Since a fixed window size is sufficient for our tests, I replaced it with a method that sets a fixed window size instead. - The element wait logic was not properly separated by intent, which caused unintended test failures. I refactored the wait methods to distinguish between presence, visibility, and clickability. - Browser built-in features such as the password manager could trigger alert dialogs that block test execution, so these have been disabled. Previously, we switched to EdgeDriver (also Chromium-based) to work around the window.maximize() bug, but the same issue occurred. Therefore, I reverted back to ChromeDriver. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6398 ### How should this be tested? - Check `test-selenium-with-spark-module-for-spark-3-5` job ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5160 from tbonelee/fix-selenium-edge. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit 776e29c) Signed-off-by: ChanHo Lee <chanholee@apache.org>
Contributor
Author
|
Thanks for the reviews. I've merged this into master and branch-0.12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Selenium-based integration tests have been failing recently.
There were several issues:
Previously, we switched to EdgeDriver (also Chromium-based) to work around the window.maximize() bug, but the same issue occurred. Therefore, I reverted back to ChromeDriver.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6398
How should this be tested?
test-selenium-with-spark-module-for-spark-3-5jobQuestions: