Skip to content

[ZEPPELIN-6358] simplify utils, promote POM usage, and consolidate base logic from #5101#5131

Merged
tbonelee merged 9 commits intoapache:masterfrom
dididy:e2e/notebook-edited
Feb 22, 2026
Merged

[ZEPPELIN-6358] simplify utils, promote POM usage, and consolidate base logic from #5101#5131
tbonelee merged 9 commits intoapache:masterfrom
dididy:e2e/notebook-edited

Conversation

@dididy
Copy link
Contributor

@dididy dididy commented Dec 30, 2025

What is this PR for?

PR Description

This PR improves the readability and maintainability of the E2E notebook tests.

  • Removed over-abstracted util and wrapper methods
  • Moved test logic from util files into the test cases
  • Simplified page objects to focus on direct UI interactions
  • Consolidated shared logic into a base page class

As a result, the tests are clearer, flatter, and easier to maintain.

What type of PR is it?

Refactoring

Todos

What is the Jira issue?

ZEPPELIN-6358

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@dididy dididy force-pushed the e2e/notebook-edited branch from 1ef52e4 to 565f6dc Compare February 22, 2026 08:01
@tbonelee tbonelee merged commit 1662cbd into apache:master Feb 22, 2026
35 of 38 checks passed
tbonelee pushed a commit that referenced this pull request Feb 22, 2026
…se logic from #5101

### What is this PR for?

### PR Description

This PR improves the readability and maintainability of the E2E notebook tests.

- Removed over-abstracted util and wrapper methods
- Moved test logic from util files into the test cases
- Simplified page objects to focus on direct UI interactions
- Consolidated shared logic into a base page class

As a result, the tests are clearer, flatter, and easier to maintain.

### What type of PR is it?
Refactoring

### Todos

### What is the Jira issue?
ZEPPELIN-6358

### How should this be tested?

### Screenshots (if appropriate)

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Closes #5131 from dididy/e2e/notebook-edited.

Signed-off-by: ChanHo Lee <chanholee@apache.org>
(cherry picked from commit 1662cbd)
@tbonelee
Copy link
Contributor

Thanks, merged into master and branch-0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants