Validate GiraphExecutor mock in Giraph PageRank test#746
Open
dileepapeiris wants to merge 1 commit intoapache:mainfrom
Open
Validate GiraphExecutor mock in Giraph PageRank test#746dileepapeiris wants to merge 1 commit intoapache:mainfrom
dileepapeiris wants to merge 1 commit intoapache:mainfrom
Conversation
Re-enable the Giraph PageRank unit test by removing the @Disabled/TODO and add stronger validations. Mock giraphExecutor.getGiraphConfiguration() in setUp, expect KeyValueProvider.NoSuchKeyException from execute via assertThrows, and verify that getGiraphConfiguration() was called. Also add necessary imports for GiraphConfiguration, KeyValueProvider, assertThrows and verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GiraphExecutormock contract inGiraphPagaRankOperatorTest.@Disabledand replace the TODO path with deterministic assertions.giraphExecutor.getGiraphConfiguration()is both stubbed and verified during operator execution.Details
setUpto return a concreteGiraphConfigurationfrom the mocked executor.assertThrows(KeyValueProvider.NoSuchKeyException.class, ...)around execution to validate the early configuration path without depending on full Giraph runtime success.GiraphExecutor.Validation
./mvnw -pl wayang-platforms/wayang-giraph -Dtest=GiraphPagaRankOperatorTest test