-
Notifications
You must be signed in to change notification settings - Fork 3.8k
docs: update http to https in license link #18688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AshwiniBokka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a minor but significant security improvement by upgrading the Apache license link within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Thank you for this contribution. Updating the license link in README.md from HTTP to HTTPS is a good security improvement. The change is correct and follows best practices.
To make this change more comprehensive, I'd suggest also updating the http links to https in the LICENSE file. I noticed similar http://www.apache.org/licenses/ links on lines 3 and 195 of that file. Applying the same update there would make your contribution even more complete.
cchung100m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks to @AshwiniBokka
Please re-run the CI after fixing the failed: PR body must not tag anyone but found these usernames: ['@gmail']
|
@tvm-bot please run ci |
|
@gemini-code-assist @cchung100m Thanks for catching this! I've updated the LICENSE file as suggested, changing http to https on lines 3 and 195. All requested changes are now complete. |
|
Thanks for the update, @AshwiniBokka! I've reviewed the changes and confirmed that the |
cchung100m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks prompt reply. we still encounter lint error and please recheck the change, thanks.
|
@tvm-bot please run ci |
1 similar comment
|
@tvm-bot please run ci |
|
@cchung100m I've exhaustively verified this PR: Changes Made:
Verification:
The ASF header check continues to fail despite correct changes. Could you please: This has been blocking for 24+ hours despite correct implementation. |
|
@tvm-bot please run ci |
First-time contributed to Apache TVM.
Changes:
Why:
Signed-off-by: Ashwini Bokka