-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Relax][NN] Add batch_flatten operator #18677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the relax.nn.batch_flatten operator, which is a great addition for CoreML backend support. The implementation is clean and follows the existing structure for Relax operators well. You've included comprehensive changes across the C++ implementation, Python bindings, legalization, and enabled it for the CoreML backend. The unit tests are thorough, covering correctness, struct info inference with various static and symbolic shapes, and legalization.
I found one potential issue in the legalization logic that could lead to a crash when dealing with inputs of unknown shape. I've left a specific comment with a suggested fix. Other than that, the changes look excellent.
b665ce8 to
21c4563
Compare
21c4563 to
18c91ea
Compare
Why
The
batch_flattenoperator was needed for CoreML backend support but was not implemented in Relax, causing the CoreML pattern and converter to be commented out.How
relax.nn.batch_flattenwith struct info inferencerelax.op.nntopi.reshapenn.batch_flatten