Parallelize dir-sync on graceful shutdowns#12996
Draft
zwoop wants to merge 2 commits intoapache:masterfrom
Draft
Parallelize dir-sync on graceful shutdowns#12996zwoop wants to merge 2 commits intoapache:masterfrom
zwoop wants to merge 2 commits intoapache:masterfrom
Conversation
This will make normal ATS shutdowns come down quicker, specially on boxes with a lot of drives. This is similar to the new parallel sync options under normal operations, except this will always Parallelize as much as needed.
Contributor
Author
|
This is not tested, I'd like our team to try it first, but also looking for some AI lovin' reviews. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce graceful shutdown time for Apache Traffic Server by parallelizing the cache directory flush that happens during shutdown, targeting one worker per physical cache disk.
Changes:
- Build a disk→stripe index map for shutdown syncing.
- Spawn one
std::threadper disk to callStripeSM::shutdown()for that disk’s stripes.
You can also share your feedback on Copilot code review. Take the survey.
Fix lambda reference capture bug where all threads processed the last disk's stripes instead of their own; fix shared 0xdeadbeef EThread* sentinel by using a thread_local variable to give each OS thread a unique identity for MUTEX_TAKE_LOCK.
zwoop
force-pushed
the
ParallelDirSyncShutdown
branch
from
ff321da to
3cfb438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make normal ATS shutdowns come down quicker, specially on boxes with a lot of drives. This is similar to the new parallel sync options under normal operations, except this will always Parallelize as much as needed.