Add additional unit tests for compute and computeIfAbsent in ParameterMap#958
Open
YCharanGowda wants to merge 3 commits intoapache:mainfrom
Open
Add additional unit tests for compute and computeIfAbsent in ParameterMap#958YCharanGowda wants to merge 3 commits intoapache:mainfrom
YCharanGowda wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
The first two test make no difference to the code coverage. Nor do they follow the pattern of the existing tests - which they should. The only reason there is a marginal increase in code coverage is Implement the first two tests in a manner consistent with the existing tests (hint the PR should extend the existing tests - not add new ones) then there might be some value in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional unit tests to improve coverage of the ParameterMap class.
New test cases added:
These tests verify that the map remains immutable when additional Map API methods are used after locking.
This change does not modify existing logic and only improves test coverage.
Please review. This is my first code contribution to Apache Tomcat.