THRIFT-5933: c_glib: reject oversized Unix socket paths in thrift_socket_open()#3356
Open
neosys007 wants to merge 1 commit intoapache:masterfrom
Open
THRIFT-5933: c_glib: reject oversized Unix socket paths in thrift_socket_open()#3356neosys007 wants to merge 1 commit intoapache:masterfrom
neosys007 wants to merge 1 commit intoapache:masterfrom
Conversation
…ket_open() thrift_socket_open() still copies the configured Unix socket path directly into a stack sockaddr_un and then connects it. The path is stored via a GObject property and is not checked against sizeof(pin.sun_path) before the copy. Reject Unix socket paths that do not fit in the local sockaddr_un.sun_path buffer before building the sockaddr and connecting the socket. Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the client-side Unix socket path copy in the C GLib transport.
In current head,
thrift_socket_open()builds a stacksockaddr_unand copiestsocket->pathintosun_pathwithstrlen(path) + 1. That only works when the configured path is shorter than the destination buffer; otherwise the copy can run past the end of the localsockaddr_unbeforeconnect()is even called.The fix mirrors the server-side transport:
I also added regression coverage in
lib/c_glib/test/testtransportsocket.cthat checks the client open path rejects an overlong Unix socket path cleanly.Validation performed locally:
git diff --checkRelated Jira: