Skip to content

Add test coverage for private_optional + template_streamop combined#3346

Merged
Jens-G merged 1 commit intoapache:masterfrom
zsy056:private_optional_ostream
Mar 25, 2026
Merged

Add test coverage for private_optional + template_streamop combined#3346
Jens-G merged 1 commit intoapache:masterfrom
zsy056:private_optional_ostream

Conversation

@zsy056
Copy link
Copy Markdown
Contributor

@zsy056 zsy056 commented Mar 17, 2026

…fix generator bugs (#14)

  • Add test coverage for private_optional + template_streamop combined, fix generator bugs
  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

…fix generator bugs (#14)

* Add test coverage for private_optional + template_streamop combined, fix generator bugs


Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: zsy056 <1074382+zsy056@users.noreply.github.com>
@mergeable mergeable bot added the c++ label Mar 17, 2026
@zsy056 zsy056 changed the title Add test coverage for private_optional + template_streamop combined; Add test coverage for private_optional + template_streamop combined Mar 17, 2026
@mergeable mergeable bot added the compiler label Mar 17, 2026
@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented Mar 21, 2026

I would love it some Thrift C++ folks can look at this.

@Jens-G Jens-G merged commit 13cdb44 into apache:master Mar 25, 2026
80 checks passed
@mergeable mergeable bot added the build and general CI cmake, automake and build system changes label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build and general CI cmake, automake and build system changes c++ compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants