TEZ-4696 Fix Maven build: register generated-sources and fork compiler to resolve test-compile failures#469
Open
lewismc wants to merge 1 commit intoapache:masterfrom
Open
TEZ-4696 Fix Maven build: register generated-sources and fork compiler to resolve test-compile failures#469lewismc wants to merge 1 commit intoapache:masterfrom
lewismc wants to merge 1 commit intoapache:masterfrom
Conversation
…r to resolve test-compile failures
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
thanks for this patch @lewismc so far! can you please elaborate on what test-compile failures you faced? it would help to fully review and approve this patch and make sure only necessary pom.xml changes go in UPDATE: I mean, I saw some details on Jira, I'm rather interested how you were able to reproduce a build failure |
Member
Author
|
Hi @abstractdog thanks for looking at this patch. Here’s my steps to justify this patch The install will not complete successfully unless this patch is applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for TEZ-4696. I was literally forced to implement this patch to build the project
Thanks for any review.