fix: support more java.time inputs in timestamp parsing #4139
+48
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bobbai00 Please review this PR. |
bobbai00
changed the title
bobbai00
approved these changes
Dec 28, 2025
Contributor
bobbai00
left a comment
bobbai00
left a comment
There was a problem hiding this comment.
LGTM. Left few minor comments
common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/AttributeTypeUtils.scala
Outdated
Show resolved
Hide resolved
common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/AttributeTypeUtils.scala
Outdated
Show resolved
Hide resolved
common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/AttributeTypeUtils.scala
Outdated
Show resolved
Hide resolved
common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/AttributeTypeUtils.scala
Outdated
Show resolved
Hide resolved
common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/AttributeTypeUtils.scala
Outdated
Show resolved
Hide resolved
...workflow-core/src/test/scala/org/apache/texera/amber/core/tuple/AttributeTypeUtilsSpec.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks. Done. |
Contributor
|
@bobbai00 Can we merge this PR now? |
Contributor
Author
|
@chenlica can you approve the workflows to run? |
Contributor
|
@carloea2 There is a failed check. Please look into it. |
Contributor
Author
|
It should be fine now.. |
Contributor
Author
|
@chenlica Done. |
Contributor
|
@carloea2 Please mention the related issue and close that issue as well. |
Contributor
Author
|
I do not have permission to close issues, can you do that? thanks I also added the issue to the PR description. |
Contributor
|
I closed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Added support in
parseTimestamp(fieldValue: Any)for additionaljava.timeinput types:LocalDateTime→Timestamp.valueOf(ldt)Instant→Timestamp.from(inst)OffsetDateTime→Timestamp.from(odt.toInstant)ZonedDateTime→Timestamp.from(zdt.toInstant)LocalDate→Timestamp.valueOf(ld.atStartOfDay())Any related issues, documentation, discussions?
How was this PR tested?
Added unit tests covering the new
java.timecases for timestamp parsing:LocalDateTime,Instant,OffsetDateTime,ZonedDateTime, andLocalDateAttributeTypeExceptionWas this PR authored or co-authored using generative AI tooling?
No